Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check err != nil after !d.IsNewResource() && tfresource.NotFound() #38512

Merged
merged 7 commits into from
Jul 24, 2024
Merged

Check err != nil after !d.IsNewResource() && tfresource.NotFound() #38512

merged 7 commits into from
Jul 24, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 24, 2024 •
edited
Loading

Description

Ensure that err is checked in resource Read after the usual if !d.IsNewResource() && tfresource.NotFound() check.

Relations

Closes #38504.
Relates #38292.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccTimestreamWriteTable_basic\|TestAccTimestreamWriteTable_disappears' PKG=timestreamwrite
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/timestreamwrite/... -v -count 1 -parallel 20  -run=TestAccTimestreamWriteTable_basic\|TestAccTimestreamWriteTable_disappears -timeout 360m
=== RUN   TestAccTimestreamWriteTable_basic
=== PAUSE TestAccTimestreamWriteTable_basic
=== RUN   TestAccTimestreamWriteTable_disappears
=== PAUSE TestAccTimestreamWriteTable_disappears
=== CONT  TestAccTimestreamWriteTable_basic
=== CONT  TestAccTimestreamWriteTable_disappears
--- PASS: TestAccTimestreamWriteTable_disappears (14.47s)
--- PASS: TestAccTimestreamWriteTable_basic (14.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite	19.590s

@ewbankkit ewbankkit requested a review from a team as a code owner July 24, 2024 15:11
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added service/chime Issues and PRs that pertain to the chime service. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. linter Pertains to changes to or issues with the various linters. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. size/S Managed by automation to categorize the size of a PR. labels Jul 24, 2024
jar-b
jar-b approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Jul 24, 2024
@ewbankkit ewbankkit merged commit ceae910 into main Jul 24, 2024
33 checks passed
@ewbankkit ewbankkit deleted the semgrep-IsNewResource+tfresource.NotFound-check-err branch July 24, 2024 16:03
@github-actions github-actions bot added this to the v5.60.0 milestone Jul 24, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Jul 24, 2024
Update CHANGELOG.md for #38512
bf51b1f
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. linter Pertains to changes to or issues with the various linters. service/chime Issues and PRs that pertain to the chime service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.60.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Crash while trying to add a Timestream table to my infrastructure
2 participants
@ewbankkit @jar-b